Repository navigation
Conversation
Bumps @codspeed/tinybench-plugin 6.0.1 to 6.1.0 and tinybench 6.2.2 to 6.2.3 from dependabot PR #57, without its postgres 3.4.9 to 4.0.0 bump. @rocicorp/zero 1.11.4 depends on postgres 3.4.7. The harness hands its own postgres.js client to Zero's adapter, so with 4.0.0 the oracle ran a client Zero does not ship with: v4 types parameters differently, and eight wire tests in test_mutate.py and test_sql.py diverged (an array written to a text column came back as '{{"false' instead of 'false'). tests/test_pin.py now checks that each harness's postgres is on the major @rocicorp/zero depends on, and dependabot skips postgres major bumps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Merging this PR will improve performance by 13.14%2 warnings
Performance Changes
Tip Curious why performance improved? Comment Comparing |
Summary
Takes the bench tool bumps from #57 (
@codspeed/tinybench-plugin6.0.1 to 6.1.0,tinybench6.2.2 to 6.2.3) and leavespostgreson 3.4.9 instead of 4.0.0.@rocicorp/zero1.11.4 depends onpostgres3.4.7. The harness hands its own postgres.js client to Zero's adapter (zeroPostgresJS(schema, postgres(url))), so with 4.0.0 the oracle ran on a client Zero does not ship with. v4 lets the server type every parameter, and eight wire tests diverged on #57 (test_pushes_match_upstreamand the matchingtest_sql.pycases): an array written to a text column came back as'{{"false'from the oracle instead of'false'. The CodSpeed regression onquery.simple.b1(-18.27%, flagged as different hardware) came from the same run.tests/test_pin.py: new check that each harness'spostgresis on the major@rocicorp/zerodepends on..github/dependabot.yml: skippostgresmajor bumps, which move with Zero, like@rocicorp/zeroitself.Evidence
assert '4' == '3'; green on this branch (pytest tests/test_pin.py: 5 passed).ruff check,ruff format --check,ty checkon the changed test: clean.Supersedes #57.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.